Skip to content

Drop basic-toml in favor of more widely used toml crate#239

Merged
dtolnay merged 1 commit intomasterfrom
toml
Mar 16, 2024
Merged

Drop basic-toml in favor of more widely used toml crate#239
dtolnay merged 1 commit intomasterfrom
toml

Conversation

@dtolnay
Copy link
Copy Markdown
Owner

@dtolnay dtolnay commented Aug 25, 2023

Closes #257.

@dtolnay dtolnay closed this Aug 25, 2023
@dtolnay dtolnay deleted the toml branch August 25, 2023 01:12
@dtolnay dtolnay restored the toml branch March 16, 2024 21:04
@dtolnay dtolnay reopened this Mar 16, 2024
@dtolnay dtolnay closed this Mar 16, 2024
@dtolnay dtolnay deleted the toml branch March 16, 2024 21:07
@dtolnay dtolnay restored the toml branch March 16, 2024 22:00
@dtolnay dtolnay reopened this Mar 16, 2024
@dtolnay dtolnay merged commit 93b44ef into master Mar 16, 2024
@dtolnay dtolnay deleted the toml branch March 16, 2024 22:02
csnover added a commit to csnover/trybuild that referenced this pull request Mar 30, 2024
Replacing basic-toml crate in dtolnay#239 raised MSRV
to 1.67 (toml_datetime specifies this minimum), but CI workflow was
updated to 1.70 in that PR, so this patch raises MSRV to 1.70
instead.

A reference to even older MSRV in the README is removed entirely
since this information lives in Cargo.toml as of Rust 1.56.
csnover added a commit to csnover/binrw that referenced this pull request Mar 30, 2024
Upstream switched from basic-toml to toml in dtolnay/trybuild#239
which leads to a dependency on toml_datetime which has an MSRV of
Rust 1.67; since this is just a dev-dependency, there is no reason
to increase MSRV, so just pin the trybuild dependency to the
previous version until there is some new feature that requires
raising binrw MSRV again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure when running with a valid Cargo.toml that uses dotted key syntax

1 participant