Conversation
takumi-earth
pushed a commit
to earthlings-dev/thiserror
that referenced
this pull request
Jan 27, 2026
Add logic to determine whether unnamed fmt arguments are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for an upcoming change that disallows extra positional fmt arguments in the format string of a tuple struct or tuple variant due to ambiguity. For example in
#[error("{} {0}", $N)] Variant(i32)it is ambiguous whether the{0}refers to $N vs &self.0. One would need to write a named#[error("{n} {n}", n = $N)]for the former or a numbered#[error("{n} {0}", n = $N)]for the latter, both of which have an obviously unambiguous meaning.