Add Fields::iter_member#1716
Merged
dtolnay merged 2 commits intodtolnay:masterfrom Aug 11, 2024
Fancyflame:master
Merged
Conversation
the span of unnamed field member will fallback to `Span::call_site` if `Spanned` trait is not available
| /// An iterator over the fields of a struct or variant as [`Member`]s. | ||
| #[cfg_attr(docsrs, doc(cfg(any(feature = "full", feature = "derive"))))] | ||
| #[derive(Clone)] | ||
| pub struct IterMember<'a> { |
Contributor
There was a problem hiding this comment.
this type should be publicly accessible ... so probably don't put it in its own private module
Contributor
Author
There was a problem hiding this comment.
I have also considered this issue before, but I noticed that many iterator function s under Generics also return private types. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acts like
Fields::iter, but map itsFielditems toMember.For instance, in this struct
We use
iter_memberto access its fields, and implementClonefor it.Then it generates
There is a similar effect on unnamed fields in which iterates
Member::Indexinstead.