Skip to content

Add check in ScheduledReporter's stop method#4246

Merged
joschi merged 2 commits intodropwizard:release/4.2.xfrom
ummels:feature/scheduled-reporter-stop-check-if-started
Oct 3, 2024
Merged

Add check in ScheduledReporter's stop method#4246
joschi merged 2 commits intodropwizard:release/4.2.xfrom
ummels:feature/scheduled-reporter-stop-check-if-started

Conversation

@ummels
Copy link
Copy Markdown
Contributor

@ummels ummels commented Jun 16, 2024

Check whether reporter is started before reporting metrics one last time.

Closes #4135

@joschi joschi force-pushed the feature/scheduled-reporter-stop-check-if-started branch from 0f9a4f0 to cd6d65f Compare October 3, 2024 16:09
@joschi joschi added the bug label Oct 3, 2024
Copy link
Copy Markdown
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ummels Thanks for your contribution! ❤️

@joschi joschi enabled auto-merge (squash) October 3, 2024 16:10
@joschi joschi disabled auto-merge October 3, 2024 16:42
@joschi joschi enabled auto-merge (squash) October 3, 2024 16:42
@joschi joschi merged commit f0bb90d into dropwizard:release/4.2.x Oct 3, 2024
joschi pushed a commit that referenced this pull request Oct 3, 2024
joschi added a commit that referenced this pull request Oct 3, 2024
Refs #4246
Refs #4135

Co-authored-by: Michael Ummels <michael@ummels.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScheduledReporter reports metrics when stopped/closed even when not started

2 participants