Closed
Conversation
doy
reviewed
Mar 25, 2023
Owner
doy
left a comment
There was a problem hiding this comment.
this overall looks reasonable, other than the thing i noted. could you also add some tests?
| if dim { | ||
| write_param!(2); | ||
| } else { | ||
| write_param!(22); |
Owner
There was a problem hiding this comment.
this isn't correct - text that is only bold will end up no longer being bold after this, because turning off dim also turns off bold. you'll probably need to handle these cases together to make sure all of the different potential settings work together properly.
chris-olszewski
added a commit
to vercel/turborepo
that referenced
this pull request
Mar 6, 2024
### Description Due to our use case we need to extend `vt100` with some functionality. The functionality can be added upstream, but based on the age of PRs on the project, we cannot wait for this to happen. Reviewing instructions: I quick documented changes I made from the straight `vt100` crate. Significant behavior/bug fixes will be added in future PRs General plans of changes: - Cherry pick [underflow fix](doy/vt100-rust#11) - [Support dimmed formatting](doy/vt100-rust#9) - Add a version of `Screen` that displays *all* content including lines that are now in the scrollback - Some [perf fixes](doy/vt100-rust#14) ### Testing Instructions Verified existing test suite passes on my machine. Verify test suite passes on CI
Owner
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the code
2to initiate dim formatting and22to exit it.22is also used to exit bold formatting.I looked the codes up at https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters