Skip to content

[release/9.0.3xx] Update dependencies from dotnet/msbuild#47487

Merged
dotnet-maestro[bot] merged 2 commits intorelease/9.0.3xxfrom
darc-release/9.0.3xx-ca288b83-896a-4dff-a3d4-a8a75281ad44
Mar 13, 2025
Merged

[release/9.0.3xx] Update dependencies from dotnet/msbuild#47487
dotnet-maestro[bot] merged 2 commits intorelease/9.0.3xxfrom
darc-release/9.0.3xx-ca288b83-896a-4dff-a3d4-a8a75281ad44

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 12, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
811fbee 
…0311.14

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25160-08 -> To Version 17.14.0-preview-25161-14
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Mar 12, 2025
@v-wuzhai
Copy link
Copy Markdown
Contributor

v-wuzhai commented Mar 12, 2025 •
edited
Loading

@dotnet/source-build PTAL

##[error].packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.25111.5/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Formats.Nrbf.9.0.0
Prebuilt usages are different from the baseline found at '/__w/1/s/eng/SourceBuildPrebuiltBaseline.xml'. If it's acceptable to update the baseline, copy the contents of the automatically generated baseline '/__w/1/s/artifacts/sb/prebuilt-report/generated-new-baseline.xml'.

@edvilme
Copy link
Copy Markdown
Contributor

edvilme commented Mar 13, 2025

Hello @dotnet/source-build do we have any updates on why this might be failing?

@NikolaMilosavljevic
Copy link
Copy Markdown
Member

NikolaMilosavljevic commented Mar 13, 2025

Hello @dotnet/source-build do we have any updates on why this might be failing?

We don't build source-build in 9.0.3xx band, so this new prebuilt should be added to https://github.com/dotnet/sdk/blob/release/9.0.3xx/eng/SourceBuildPrebuiltBaseline.xml the same way it's done in msbuild repo: https://github.com/dotnet/msbuild/blob/a2cac59fdfbef73025329990864c1f8d2c7ece23/eng/SourceBuildPrebuiltBaseline.xml#L26

msbuild change was made last week (dotnet/msbuild#11145) and is flowing in with this PR.

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner March 13, 2025 18:17
@NikolaMilosavljevic
Copy link
Copy Markdown
Member

NikolaMilosavljevic commented Mar 13, 2025

@edvilme I've pushed a fix for source-build.

@dotnet-maestro dotnet-maestro bot merged commit 2756268 into release/9.0.3xx Mar 13, 2025
35 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/9.0.3xx-ca288b83-896a-4dff-a3d4-a8a75281ad44 branch March 13, 2025 20:27
@renovate renovate bot mentioned this pull request Jul 8, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthalman mthalman mthalman approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v-wuzhai @edvilme @NikolaMilosavljevic @mthalman