Skip to content

[REF] SolutionProjectModel Full Paths#47422

Merged
edvilme merged 1 commit intodotnet:release/9.0.2xxfrom
edvilme:sln-project-paths
Mar 11, 2025
Merged

[REF] SolutionProjectModel Full Paths#47422
edvilme merged 1 commit intodotnet:release/9.0.2xxfrom
edvilme:sln-project-paths

Conversation

@edvilme
Copy link
Copy Markdown
Contributor

@edvilme edvilme commented Mar 10, 2025

Nit update to ensure full project paths

Copilot AI review requested due to automatic review settings March 10, 2025 19:02
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Mar 10, 2025
@edvilme edvilme requested review from a team and Forgind and removed request for Copilot March 10, 2025 19:02
MiYanni
MiYanni reviewed Mar 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in relation to #47415 ?

@edvilme
Copy link
Copy Markdown
Contributor Author

edvilme commented Mar 10, 2025

Is this in relation to #47415 ?

Yes, I looked at all the places that call SolutionProjectModel::FilePath and wanted to make them all get the full path the same way. This shouldn't change functionality, but I think it is easier to read and understand :)

@edvilme edvilme enabled auto-merge (squash) March 10, 2025 20:33
@edvilme edvilme merged commit 5eb4440 into dotnet:release/9.0.2xx Mar 11, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiYanni MiYanni MiYanni approved these changes

@Forgind Forgind Awaiting requested review from Forgind

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edvilme @MiYanni