Skip to content

[release/9.0.3xx] Update dependencies from dotnet/msbuild#47184

Merged
v-wuzhai merged 4 commits intorelease/9.0.3xxfrom
darc-release/9.0.3xx-02ca0425-4de9-445e-8081-ac281d457ce5
Mar 3, 2025
Merged

[release/9.0.3xx] Update dependencies from dotnet/msbuild#47184
v-wuzhai merged 4 commits intorelease/9.0.3xxfrom
darc-release/9.0.3xx-02ca0425-4de9-445e-8081-ac281d457ce5

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 28, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
f5c23b1 
…0227.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25127-07
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Feb 28, 2025
This was referenced Feb 28, 2025
Closed
Open
Closed
@v-wuzhai v-wuzhai mentioned this pull request Feb 28, 2025
Merged
@joeloff
Copy link
Copy Markdown
Member

joeloff commented Feb 28, 2025

@edvilme Mind taking a look at the SLNX failures. Builds for 9.0.3xx were passing fine, so this may be related to msbuild changes included in this PR. The details are in the helix console log
Here's an example of one of the errors:

Failed Microsoft.DotNet.Cli.Sln.Add.Tests.GivenDotnetSlnAdd.WhenNestedProjectIsAddedSolutionFoldersAreCreatedBuild(solutionCommand: "sln", fooFirst: True, solutionExtension: ".sln") [2 s]
  Error Message:
   Expected command to pass but it did not.

Stack Trace:
     at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at Microsoft.NET.TestFramework.Assertions.CommandResultAssertions.Pass() in /_/test/Microsoft.NET.TestFramework/Assertions/CommandResultAssertions.cs:line 29
   at Microsoft.DotNet.Cli.Sln.Add.Tests.GivenDotnetSlnAdd.WhenNestedProjectIsAddedSolutionFoldersAreCreatedBuild(String solutionCommand, Boolean fooFirst, String solutionExtension) in /_/test/dotnet-sln.Tests/GivenDotnetSlnAdd.cs:line 289
   at InvokeStub_GivenDotnetSlnAdd.WhenNestedProjectIsAddedSolutionFoldersAreCreatedBuild(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@joeloff
Copy link
Copy Markdown
Member

joeloff commented Feb 28, 2025

I just saw the comment in #47181 Do we need to skip the tests instead?

dotnet-maestro bot and others added 3 commits March 1, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
5834666 
…0228.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25128-02
@akoeplinger
Disable tests that rely on vs-solutionpersistence fix
4ca7deb
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
31baa99 
…0303.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25153-01
@v-wuzhai v-wuzhai merged commit 323e7b2 into release/9.0.3xx Mar 3, 2025
34 checks passed
@v-wuzhai v-wuzhai deleted the darc-release/9.0.3xx-02ca0425-4de9-445e-8081-ac281d457ce5 branch March 3, 2025 06:44
This was referenced Jun 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@v-wuzhai v-wuzhai v-wuzhai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeloff @v-wuzhai @akoeplinger