Unescape slnf original solution path#46833
Merged
edvilme merged 7 commits intodotnet:release/9.0.3xxfrom Feb 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/TestAssets/TestProjects/TestAppWithSlnxAndSolutionFoldersWithSpecialCharacters/App.slnf: Language not supported
- test/TestAssets/TestProjects/TestAppWithSlnxAndSolutionFoldersWithSpecialCharacters/App@something.slnx: Language not supported
Comments suppressed due to low confidence (1)
src/Cli/dotnet/SlnFileFactory.cs:96
- Verify if
Uri.UnescapeDataStringis the correct method to use for unescaping the solution path. Ensure it does not introduce any unintended side effects.
filteredSolution.Description = Uri.UnescapeDataString(originalSolutionPathAbsolute);
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/TestAssets/TestProjects/TestAppWithSlnxAndSolutionFoldersWithSpecialCharacters/App.slnf: Language not supported
- test/TestAssets/TestProjects/TestAppWithSlnxAndSolutionFoldersWithSpecialCharacters/App@something.slnx: Language not supported
aa8c191 to
b578e16
Compare
nagilson
reviewed
Feb 14, 2025
surayya-MS
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/msbuild#11050
If the original solution file name contains a special character such as
@, it will be escaped when reading the json slnf file. Hence, it looks for the file with the incorrect path. This attempts to unescape the original solution path