Skip to content

[release/8.0] Update dependencies from dotnet/sdk #93783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 5 commits into from
Oct 20, 2023
Merged

[release/8.0] Update dependencies from dotnet/sdk #93783

carlossanlop merged 5 commits into from
Oct 20, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 20, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/sdk

  • Subscription: c4f332c1-d637-4d83-a436-08dbcfd61a5a
  • Build: 2023102.8
  • Date Produced: October 20, 2023 10:11:36 AM UTC
  • Commit: 7e33fd449381b337c290a801057fdcd68c4b7220
  • Branch: refs/heads/release/8.0.1xx

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 2023102.8
cbed74b 
Microsoft.DotNet.ApiCompat.Task
 From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-rtm.23520.8
@ghost ghost added the area-codeflow for labeling automated codeflow label Oct 20, 2023
@ViktorHofer ViktorHofer mentioned this pull request Oct 20, 2023
Merged
@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Oct 20, 2023
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 20, 2023 •
edited
Loading

@carlossanlop we need to get this change merged before the snap to successfully build this repository with coherent dependencies.

@carlossanlop
Copy link
Contributor

carlossanlop commented Oct 20, 2023

@ViktorHofer @ericstj there is a new CI failure and seems to be related to this deps flow:

D:\a\_work\1\s\.packages\microsoft.dotnet.apicompat.task\8.0.100-rtm.23520.8\build\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error : API compatibility errors between 'lib/netstandard2.0/System.Security.Permissions.dll' (D:\a\_work\1\s\.packages\system.security.permissions\7.0.0\system.security.permissions.7.0.0.nupkg) and 'lib/netstandard2.0/System.Security.Permissions.dll' (D:\a\_work\1\s\artifacts\packages\Debug\Shipping\System.Security.Permissions.8.0.0-ci.nupkg): [D:\a\_work\1\s\src\libraries\System.Security.Permissions\src\System.Security.Permissions.csproj]
D:\a\_work\1\s\.packages\microsoft.dotnet.apicompat.task\8.0.100-rtm.23520.8\build\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0014: Cannot remove attribute 'System.ObsoleteAttribute' from 'System.Security.Permissions.FileIOPermissionAttribute.All'. [D:\a\_work\1\s\src\libraries\System.Security.Permissions\src\System.Security.Permissions.csproj]
D:\a\_work\1\s\.packages\microsoft.dotnet.apicompat.task\8.0.100-rtm.23520.8\build\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0014: Cannot remove attribute 'System.ObsoleteAttribute("ReflectionPermissionAttribute.ReflectionEmit has been deprecated and is not supported.")' from 'System.Security.Permissions.ReflectionPermissionAttribute.ReflectionEmit'. [D:\a\_work\1\s\src\libraries\System.Security.Permissions\src\System.Security.Permissions.csproj]
D:\a\_work\1\s\.packages\microsoft.dotnet.apicompat.task\8.0.100-rtm.23520.8\build\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0014: Cannot remove attribute 'System.ObsoleteAttribute("ReflectionPermissionAttribute.TypeInformation has been deprecated and is not supported.")' from 'System.Security.Permissions.ReflectionPermissionAttribute.TypeInformation'. [D:\a\_work\1\s\src\libraries\System.Security.Permissions\src\System.Security.Permissions.csproj]
D:\a\_work\1\s\.packages\microsoft.dotnet.apicompat.task\8.0.100-rtm.23520.8\build\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [D:\a\_work\1\s\src\libraries\System.Security.Permissions\src\System.Security.Permissions.csproj]
    0 Warning(s)
    5 Error(s)

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 20, 2023

These three additional suppressions are expected. Those attribute were suppressed before (in the GenApi attribute exclusion file which is passed to APICompat). They don't show up in main as the package baseline version is 8.0.0-rc1 there.

@build-analysis build-analysis bot mentioned this pull request Oct 20, 2023
Closed
@carlossanlop
Copy link
Contributor

carlossanlop commented Oct 20, 2023

Green :shipit:

@carlossanlop carlossanlop merged commit 9255cc6 into release/8.0 Oct 20, 2023
@carlossanlop carlossanlop deleted the darc-release/8.0-c32cda3b-8700-4d4f-9464-a51e0308b22c branch October 20, 2023 23:00
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @carlossanlop @ericstj