[release/8.0] Fix build of IJW test after VS upgrade #93649
Conversation
The latest build of VS carries a C/C++ compiler which produces warning C5271: ``` src\native\corehost\test\ijw\ijw.cpp(6): warning C5271: consider replacing #using <System.Console.dll> with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Console.dll" src\native\corehost\test\ijw\ijw.cpp(7): warning C5271: consider replacing #using <System.Runtime.Loader.dll> with command line argument /FU "F:\dotnet\runtime2\.dotnet\packs\Microsoft.NETCore.App.Ref\8.0.0-rc.1.23414.4\ref\net8.0\System.Runtime.Loader.dll" ``` This breaks the build on Windows. For now I'm disabling the warning as the real fix is more complex (we would need to calculate the path to the required assemblies in CMake somehow).
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. once ready we can merge as tell mode.
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #92878 to release/8.0 /cc @vitek-karas Customer ImpactNone TestingVerified that I can build the repo on a machine with new VS RiskBasically none - it's just suppressing a warning caused by a new version of the C++ compiler. The official build won't use that. IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@jkoritzinsky since you signed-off the main PR, can you also sign-off this backport? |
Backport of #92878 to release/8.0
/cc @vitek-karas
Customer Impact
None
Testing
Verified that I can build the repo on a machine with new VS
Risk
Basically none - it's just suppressing a warning caused by a new version of the C++ compiler. The official build won't use that.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.