[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces #93617

github-actions · 2023-10-17T17:52:34Z

Backport of #93616 to release/8.0

Customer Impact

Customers on mobile and WebAssembly platforms using bounded array types may experience crashes if the arrays are incorrectly cast to certain generic interface types. The correct behavior is to throw an InvalidCastException. This may impact customers using certain versions of xUnit for testing their mobile or WASM applications.

Testing

New CI test

Risk

Low

Fixes #93597

MichalStrehovsky · 2023-10-17T22:00:04Z

The test needs to be disabled on Native AOT. We don't support arrays with non-zero lower bounds.

MichalStrehovsky · 2023-10-17T22:02:42Z

The test needs to be disabled on Native AOT. We don't support arrays with non-zero lower bounds.

Should be added to the collection here:

runtime/src/tests/issues.targets

Lines 1119 to 1155 in 0a188dd

    
           <!-- Arrays with non-zero lower bounds --> 
        
           <!-- https://github.com/dotnet/runtimelab/issues/155 --> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_b_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_i4_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_objref_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_r4_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_r8_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_struct_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_u8_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\address_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\ldelem_get_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\address_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\gcarr_il_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\ldelem_get_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range1_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range2_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_1_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_m1_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_neg_range_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range1_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range2_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range1_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range2_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_1_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_m1_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_neg_range_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range1_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range2_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\int64\arrays\hugedim_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array2_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array3_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array3_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\tailcall\deep_array_nz_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\tailcall\deep_array_nz_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\VT\port\huge_gcref_d\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\VT\port\huge_gcref_r\*" /> 
        
           <ExcludeList Include="$(XunitTestBinBase)/JIT/Performance/CodeQuality/Benchstones/MDBenchI/MDGeneralArray/MDGeneralArray/*" />

carlossanlop · 2023-10-18T15:43:12Z

@MichalStrehovsky @lambdageek is there an additional test that needs to be disabled? There's a failure:

Queue: Build windows-x64 Checked NativeAOT
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=442686&view=logs&j=ea7d6d51-d18d-5306-47bd-e3b7db04467e&t=64748b58-8f78-5277-67c1-1790606dd9c0&l=29
Log file: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-93617-merge-8d43e23f3b464b91bf/Loader.classloader/1/console.03fe9c6e.log?helixlogtype=result

Unhandled Exception: System.PlatformNotSupportedException: Arrays with non-zero lower bounds are not supported.

lambdageek · 2023-10-18T15:54:00Z

@MichalStrehovsky @lambdageek is there an additional test that needs to be disabled? There's a failure:

Queue: Build windows-x64 Checked NativeAOT

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=442686&view=logs&j=ea7d6d51-d18d-5306-47bd-e3b7db04467e&t=64748b58-8f78-5277-67c1-1790606dd9c0&l=29

Log file: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-93617-merge-8d43e23f3b464b91bf/Loader.classloader/1/console.03fe9c6e.log?helixlogtype=result
Unhandled Exception: System.PlatformNotSupportedException: Arrays with non-zero lower bounds are not supported.

That's the test I tried to exclude. But I think I messed up the exclude target

lambdageek · 2023-10-18T19:05:14Z

Approved by tactics in email

carlossanlop · 2023-10-18T23:50:48Z

CI failure unrelated (KnownBuildError didn't tag it automatically): #90639

[mono] Disallow casts of bounded arrays to array special interfaces

915d6bb

Fixes #93597

github-actions bot requested review from lambdageek, thaystg and vargaz as code owners October 17, 2023 17:52

ghost added the area-VM-meta-mono label Oct 17, 2023

lewing approved these changes Oct 17, 2023

View reviewed changes

lewing added the Servicing-consider Issue for next servicing release review label Oct 17, 2023

lewing added this to the 8.0.0 milestone Oct 17, 2023

vargaz approved these changes Oct 17, 2023

View reviewed changes

carlossanlop mentioned this pull request Oct 17, 2023

[8.0] Windows x64 NativeAOT PNSE: Arrays with non-zero lower bounds are not supported #93632

Closed

lambdageek added 2 commits October 18, 2023 10:00

exclude lower bound regression test on NativeAOT

717de94

Merge branch 'release/8.0' into backport/pr-93616-to-release/8.0

2387f3a

try to fix nativaot exclude

835c27e

build-analysis bot mentioned this pull request Oct 18, 2023

[wasm] Runtime tests failing - _Vector2_3_4::Vector2_3_4Test.RunVector*Tests because of missing support for native libraries #93669

Closed

lambdageek added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 18, 2023

carlossanlop mentioned this pull request Oct 18, 2023

French abbreviated month names not showing up as expected #90639

Closed

carlossanlop merged commit fbd28cb into release/8.0 Oct 18, 2023

carlossanlop deleted the backport/pr-93616-to-release/8.0 branch October 18, 2023 23:54

ghost locked as resolved and limited conversation to collaborators Nov 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces #93617

[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces #93617

Uh oh!

github-actions bot commented Oct 17, 2023 •

edited by lambdageek

Loading

Uh oh!

MichalStrehovsky commented Oct 17, 2023

Uh oh!

MichalStrehovsky commented Oct 17, 2023

Uh oh!

carlossanlop commented Oct 18, 2023

Uh oh!

lambdageek commented Oct 18, 2023

Uh oh!

lambdageek commented Oct 18, 2023

Uh oh!

carlossanlop commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces #93617

[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces #93617

Uh oh!

Conversation

github-actions bot commented Oct 17, 2023 • edited by lambdageek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Customer Impact

Testing

Risk

Uh oh!

MichalStrehovsky commented Oct 17, 2023

Uh oh!

MichalStrehovsky commented Oct 17, 2023

Uh oh!

carlossanlop commented Oct 18, 2023

Uh oh!

lambdageek commented Oct 18, 2023

Uh oh!

lambdageek commented Oct 18, 2023

Uh oh!

carlossanlop commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Oct 17, 2023 •

edited by lambdageek

Loading