[release/9.0] Fix handling of appending keywords to boolean schemas. #108248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
jeffhandley
approved these changes
Sep 30, 2024
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108246 to release/9.0
/cc @eiriktsarpalis
Customer Impact
Fixes a customer-reported issue where the schema exporter will throw an exception when attempting to append default parameters to boolean schemas.
Regression
Testing
Added unit testing validating the fix. Verified with the Semantic Kernel team that the fix resolves the originally reported issue.
Risk
Low. Makes a small targeted addition to product code.