[rc2] Fix null reference exception in migrations when string has invalid store type#36669
Merged
AndriySvyryd merged 7 commits intorelease/10.0from Aug 29, 2025
Merged
[rc2] Fix null reference exception in migrations when string has invalid store type#36669AndriySvyryd merged 7 commits intorelease/10.0from
AndriySvyryd merged 7 commits intorelease/10.0from
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Null reference exception in migrations when string has invalid store type
Fix null reference exception in migrations when string has invalid store type
Aug 27, 2025
AndriySvyryd
approved these changes
Aug 27, 2025
Member
AndriySvyryd
left a comment
There was a problem hiding this comment.
@copilot Rewrite the PR summary using this template:
Fixes #{number}
**Description**
{Issue description}
**Customer impact**
{How does the reported issue affects customer's app? Are there workarounds?}
**How found**
{Was it customer reported or found during verification? How many customers are affected?}
**Regression**
{Is it a regression from a released version? Which one?}
**Testing**
{How the changes were tested}
**Risk**
{Low/Medium/High, argument why}
test/EFCore.SqlServer.Tests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.Tests/Migrations/InvalidColumnTypeIntegrationTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Member
|
@copilot Continue |
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Contributor
Author
Continued and completed all remaining tasks: ✅ Moved logic to GetColumnType method with non-nullable return type Commit cd9ba81 |
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs
Outdated
Show resolved
Hide resolved
…upportedTypeForColumn Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
artl93
approved these changes
Aug 28, 2025
Member
artl93
left a comment
There was a problem hiding this comment.
Customer reported regression restoring previous behavior
roji
reviewed
Aug 28, 2025
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs
Outdated
Show resolved
Hide resolved
SamMonoRT
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33556
Description
Fixed a NRE that occurs during migrations when a property has an invalid store type by throwing a more helpful exception.
Customer impact
Customers experience NullReferenceException during migrations when their models contain properties with incompatible store type mappings. This would cause migration generation to fail completely, preventing database schema updates. The workaround is to ensure all properties had valid type mappings or manually specify ColumnType, but this was not always clear to users.
How found
Reported by multiple customers on EF8 and EF9.
Regression
Yes, from EF7.
Testing
Test added
Risk
Low. Just throws a different exception.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.