[release/7.0] Dispose CTS in HubConnection streaming#51138
[release/7.0] Dispose CTS in HubConnection streaming#51138wtgodbe merged 1 commit intorelease/7.0from
Conversation
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
@BrennanConroy @halter73 I can merge this once it gets code reviewed |
|
Components failure is unrelated & has been fixed, merging |
Backport of #51117 to release/7.0
/cc @BrennanConroy
Dispose CTS in HubConnection streaming
Description
Fixes a memory leak in the SignalR client when using streaming.
Customer Impact
Noticed by customer when running a service with a client for multiple weeks and seeing large memory usage. Could also be seen by a more active client that makes a lot of streaming calls.
Regression?
Looks like it's been there since 3.X
Risk
Simple disposal of an object once it's done being used.
Verification
Packaging changes reviewed?