Don't partially mock the AbstractPlatform class#12114
Merged
derrabus merged 1 commit intodoctrine:3.5.xfrom Aug 6, 2025
Merged
Don't partially mock the AbstractPlatform class#12114derrabus merged 1 commit intodoctrine:3.5.xfrom
derrabus merged 1 commit intodoctrine:3.5.xfrom
Conversation
ef0b9b6 to
38aea98
Compare
morozov
approved these changes
Aug 6, 2025
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.5.x: Don't partially mock the AbstractPlatform class (doctrine#12114)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.6.x: Don't partially mock the AbstractPlatform class (doctrine#12114)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.6.x: Don't partially mock the AbstractPlatform class (doctrine#12114)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DBAL 5 is has become harder to mock the
AbstractPlatformclass because of its protected constructor. In addition to this, PHPUnit has deprecated thegetMockForAbstractClass()that we've used for that purpose (sebastianbergmann/phpunit#5241).I think, I'll be easier for us if used actual platform classes instead. In this PR, I'm defaulting to
SQLitePlatform. For some tests that tested SQL code generation, I've switched to different platforms if the test did not expect the SQLite flavor of the generated SQL.