Performance optimization in ScalarColumnHydrator::hydrateAllData()#12095
Merged
derrabus merged 1 commit intodoctrine:3.6.xfrom Aug 11, 2025
Merged
Performance optimization in ScalarColumnHydrator::hydrateAllData()#12095derrabus merged 1 commit intodoctrine:3.6.xfrom
ScalarColumnHydrator::hydrateAllData()#12095derrabus merged 1 commit intodoctrine:3.6.xfrom
Conversation
Contributor
Author
ScalarColumnHydrator::hydrateAllData()
ScalarColumnHydrator::hydrateAllData()ScalarColumnHydrator::hydrateAllData()
derrabus
approved these changes
Aug 11, 2025
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimization removes the intermediate array allocation during scalar column hydration. Instead of fetching all numeric rows and extracting the first column via array_column, it now calls fetchFirstColumn() directly. In the context of PDO, this aligns with the driver's native behavior (e.g. Doctrine\DBAL\Driver\PDO\Result::fetchFirstColumn()), allowing the hydration layer to skip redundant copying and memory usage.