Skip to content

Proxy class with BackedEnum as primary key does not convert the enum#12063

Merged
greg0ire merged 2 commits intodoctrine:3.5.xfrom
wmouwen:test/gh-10788
Jul 14, 2025
Merged

Proxy class with BackedEnum as primary key does not convert the enum#12063
greg0ire merged 2 commits intodoctrine:3.5.xfrom
wmouwen:test/gh-10788

Conversation

@wmouwen
Copy link
Copy Markdown
Contributor

@wmouwen wmouwen commented Jul 7, 2025 •
edited
Loading 

There was 1 error:

1) Doctrine\Tests\ORM\Functional\Ticket\GH12063::testProxyAssociationWithBackedEnum
Error: Object of class Doctrine\Tests\ORM\Functional\Ticket\GH12063Code could not be converted to string

vendor/doctrine/dbal/src/Driver/PDO/Statement.php:26
vendor/doctrine/dbal/src/Driver/Middleware/AbstractStatementMiddleware.php:19
vendor/doctrine/dbal/src/Logging/Statement.php:35
vendor/doctrine/dbal/src/Statement.php:93
src/Persisters/Entity/BasicEntityPersister.php:257
src/UnitOfWork.php:1057
src/UnitOfWork.php:402
src/EntityManager.php:268
tests/Doctrine/Tests/ORM/Functional/Ticket/GH12063.php:54

Affected versions: 3.0.0 through 4.0.x

@wmouwen wmouwen force-pushed the test/gh-10788 branch 4 times, most recently from 42206e4 to 2afa331 Compare July 12, 2025 15:29
greg0ire
greg0ire approved these changes Jul 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but… people use enums as ID? 🤯

@greg0ire greg0ire added the Bug label Jul 13, 2025
@wmouwen wmouwen mentioned this pull request Jul 14, 2025
Closed
@greg0ire greg0ire added this to the 3.5.1 milestone Jul 14, 2025
@greg0ire greg0ire merged commit 23b74e4 into doctrine:3.5.x Jul 14, 2025
85 checks passed
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Jul 14, 2025

Thanks @wmouwen !

@wmouwen wmouwen mentioned this pull request Jul 14, 2025
Open
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Merged
greg0ire
greg0ire reviewed Oct 8, 2025
View reviewed changes
tests/Doctrine/Tests/ORM/Functional/Ticket/GH12063.php
use Doctrine\ORM\Mapping\Id;
use Doctrine\Tests\OrmFunctionalTestCase;

class GH12063 extends OrmFunctionalTestCase
Copy link
Copy Markdown
Member

@greg0ire greg0ire Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derrabus this test files misses a Test suffix 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@wmouwen @greg0ire @SenseException