Merged
Conversation
Sudden upgrades can lead to broken builds. For instance, the latest versions require us to install phpDocumentor/filesystem. Let us do the upgrades in a controlled way from time to time instead.
morozov
approved these changes
Feb 3, 2025
morozov
reviewed
Feb 3, 2025
Comment on lines
+32
to
+35
| composer require --dev | ||
| phpdocumentor/guides-cli:1.7.0 | ||
| phpdocumentor/filesystem:1.7.0 | ||
| --no-update |
Member
There was a problem hiding this comment.
Personally, I find this YAML syntax quite misleading. It reads like multiple commands, and one cannot just copy-paste it and run in their shell. Could we keep it as a single line? It's not that long.
Member
Author
There was a problem hiding this comment.
I will try to remember to do that next try I upgrade these versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sudden upgrades can lead to broken builds. For instance, the latest versions require us to install
phpDocumentor/filesystem. Let us do the upgrades in a controlled way from time to time instead.Proof: doctrine/orm#11818