Skip to content

cache-binary input to enable/disable caching binary to GHA cache backend#300

Merged
crazy-max merged 2 commits intodocker:masterfrom
crazy-max:cache-binary
Feb 23, 2024
Merged

cache-binary input to enable/disable caching binary to GHA cache backend#300
crazy-max merged 2 commits intodocker:masterfrom
crazy-max:cache-binary

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 23, 2024

follow-up docker/actions-toolkit#257

@nicks It should mitigate your issue related to #293. We could also save cache in post action step like you did in docker/actions-toolkit#241. I can carry this if you want 🙏

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review February 23, 2024 10:03
Copy link
Contributor

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicks
Copy link
Contributor

nicks commented Feb 23, 2024

i closed the other pr -- it might be still worth doing at some point, but less urgent now that we figured out the real issue

@crazy-max crazy-max merged commit 0d103c3 into docker:master Feb 23, 2024
@crazy-max crazy-max deleted the cache-binary branch February 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants