enforce baseUrl to api.github.com if action used on GHES#192
Merged
crazy-max merged 3 commits intodocker:masterfrom Jan 28, 2023
Merged
enforce baseUrl to api.github.com if action used on GHES#192crazy-max merged 3 commits intodocker:masterfrom
crazy-max merged 3 commits intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Member
Author
|
Thanks again @rmg! |
This was referenced Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #191 (comment)
We need to enforce the
baseUrlin the Octokit client for GHES users otherwise the it will talk to the GHES API and notapi.github.comAlso adds extra commit with a note in the README for GHES users and handle the
github_tokeninput correctly for them.Thanks for the feedback @rmg!