Merged
Conversation
| ----- | ||
| ### Upgrade Notes | ||
| - Bumped minimum engine API version to 1.24 | ||
| - Bumped default engine API version to 1.44 (Moby 25.0) |
Contributor
There was a problem hiding this comment.
If #3261 is planned to get merged for 7.1.0, this needs to be updated.
Member
There was a problem hiding this comment.
We were discussing that one, and maybe (given that there may still be some questions remaining there), we should skip that one for now, and leave it for the next release.
laurazard
approved these changes
May 23, 2024
Member
laurazard
left a comment
There was a problem hiding this comment.
Left a couple of nits (just removing periods as I don't think we tend to use them, I might've left them there myself though 😅), but otherwise LGTM.
b489cf0 to
b08d27f
Compare
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
b08d27f to
4f2a26d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.