Merged
Conversation
See docker#3259 attempts for more details Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
Contributor
Author
|
Also updates the |
Contributor
Author
|
All failures are related to the requests 2.32+ changes, and will be fixed with #3257 after this CI fix gets merged |
Comment on lines
63
to
68
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| fetch-tags: true | ||
| - name: make ${{ matrix.variant }} |
There was a problem hiding this comment.
not sure what the expected behavior here is:
$ git clone --depth=0 git@github.com:docker/docker-py.git
fatal: depth 0 is not a positive numberedit: it seems to be checking it out, so nevermind.
Contributor
Author
There was a problem hiding this comment.
it's a value that's valid for the gh action, it just means fetch all essentially
Contributor
Author
There was a problem hiding this comment.
https://github.com/actions/checkout for reference
Member
|
We verified all failures are unrelated to this change in #3259, which also contains these changes; bringing this one in so that we can rebase the other PR(s) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fetch-depth:0andfetch-tags: trueto successfully get the repo tags, needed to properly build the library.See #3259 attempts for more details