Modernize build to use hatchling and hatch-vcs#3207
Merged
milas merged 3 commits intodocker:mainfrom Mar 29, 2024
Merged
Conversation
802838f to
854dd83
Compare
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
milas
approved these changes
Mar 29, 2024
Contributor
milas
left a comment
There was a problem hiding this comment.
A HUGE thanks from me, this is long overdue and looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the packaging for
docker-pyfrom the old and bustedsetup.cfg+setup.pystuff to PEP517 Hatch'shatchlingand thehatch-vcsplugin to provide whatsetuptools_scmdid.Aside from superficial changes in metadata structure (and file times being static for more reproducible builds), the resulting wheels are the same (and of course the
_versionfile is different because there's two extra commits here...):There's also an added GitHub Actions workflow that builds the wheel even when not publishing, so you can look at the results for any given PR.
Note
This PR includes #3205 – it drops
packagingout of the requirements.