Skip to content

Bump default API version to 1.43 (Moby 24.0)#3199

Merged
glours merged 1 commit intodocker:mainfrom
vvoland:engine-24
Dec 20, 2023
Merged

Bump default API version to 1.43 (Moby 24.0)#3199
glours merged 1 commit intodocker:mainfrom
vvoland:engine-24

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Dec 15, 2023

Update API version to the latest maintained release.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>

DEFAULT_DOCKER_API_VERSION = '1.41'
DEFAULT_DOCKER_API_VERSION = '1.43'
MINIMUM_DOCKER_API_VERSION = '1.21'
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also start looking at raising this minimum, but I don't know if there's code specific in docker-py that handles differences between versions @milas ?

We're starting to deprecate old API versions, and the initial step is to disable (by default) API versions < 1.24. API 1.24 is the last version of the API before introduction of API version negotiation, so that's the version the CLI falls back to if it's unable to negotiate.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants