Conversation
Closes: docker#3195 Related: opencontainers/distribution-spec#498 Signed-off-by: Sven Kieske <kieske@osism.tech>
|
further notice: I did fix the ruff warning about |
|
Make sure to add a simple test like: def test_build_with_ports_on_tag(self):
self.client.build(".", tag="registry.example.com:443/my-img:latest")on r"my-regex"instead of "my-regex" |
There are some xfails here for cases that the regex is not currently handling. It's too strict for IPv6 domains at the moment. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
left a comment
There was a problem hiding this comment.
Thanks for the bugfix!
I addressed the lint issue (it was valid but very subtle btw: needed to use r"" strings each time for the concatenation 😵) and added some test cases from the distribution/reference codebase.
(There's some xfails on the IPv6 cases which can be addressed separately.)
|
When can we expect a release including this fix ? |
|
Thanks @milas for taking over (I was first on PTO, then this issue was drowned in my inbox due to other issues)! a new release would be highly appreciated for our downstream usage! |
Closes: #3195
Related: opencontainers/distribution-spec#498
notice: there is a false positive warning from ruff during
make test:but it's a valid escape sequence, because it's a regex, had no idea yet how to fix this without introducing more complexity.