client: remove some indirection and touch-up GoDoc#342
Merged
thaJeztah merged 1 commit intodocker:masterfrom Oct 28, 2024
Merged
client: remove some indirection and touch-up GoDoc#342thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Both NewShellProgramFunc and NewShellProgramFuncWithEnv were using createProgramCmdRedirectErr under the hood, but NewShellProgramFunc had an extra indirection through NewShellProgramFuncWithEnv. Make both a direct wrapper for createProgramCmdRedirectErr instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 53.42% 53.26% -0.16%
==========================================
Files 9 9
Lines 672 674 +2
==========================================
Hits 359 359
- Misses 268 270 +2
Partials 45 45 ☔ View full report in Codecov by Sentry. |
crazy-max
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both NewShellProgramFunc and NewShellProgramFuncWithEnv were using createProgramCmdRedirectErr under the hood, but NewShellProgramFunc had an extra indirection through NewShellProgramFuncWithEnv.
Make both a direct wrapper for createProgramCmdRedirectErr instead.