Skip to content

Dockerfile: bump xx to v1.5.0#339

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_xx
Oct 25, 2024
Merged

Dockerfile: bump xx to v1.5.0#339
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_xx

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Oct 24, 2024

full diff: tonistiigi/xx@v1.4.0...v1.5.0

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah
thaJeztah commented Oct 24, 2024
View reviewed changes
Dockerfile
ARG GO_VERSION=1.21.10
ARG XX_VERSION=1.4.0
ARG XX_VERSION=1.5.0
ARG OSXCROSS_VERSION=11.3-r7-debian
Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazy-max should this one also be updated to a newer version? https://hub.docker.com/r/crazymax/osxcross/tags

Copy link
Copy Markdown
Member

@crazy-max crazy-max Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to bump to 14.5 yet but 11.3-r8 would be good.

@thaJeztah thaJeztah self-assigned this Oct 24, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.42%. Comparing base (58c87f0) to head (2d241f3).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   53.42%   53.42%           
=======================================
  Files           9        9           
  Lines         672      672           
=======================================
  Hits          359      359           
  Misses        268      268           
  Partials       45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 24, 2024

This one's still failing unfortunately;

 > [linux/amd64->arm/v6 base 1/1] RUN xx-apt-get install -y binutils gcc libc6-dev libgcc-10-dev libsecret-1-dev pkg-config:
33.81 distribution that some required packages have not yet been created
33.81 or been moved out of Incoming.
33.83 The following information may help to resolve the situation:
33.83 
33.83 The following packages have unmet dependencies:
34.20  libc6-dev:armel : Depends: linux-libc-dev:armel but it is not going to be installed
34.21  libnsl-dev:armel : Depends: libnsl2:armel (= 1.3.0-2) but it is not installable
34.22  libsepol1-dev:armel : Depends: libsepol1:armel (= 3.1-1) but it is not going to be installed
34.23  libtirpc-dev:armel : Depends: libtirpc3:armel (= 1.3.1-1+deb11u1) but it is not installable
34.31 E: Unable to correct problems, you have held broken packages.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 24, 2024

ah! arm32 packages (armel) 🤔

@thaJeztah
Dockerfile: bump xx to v1.5.0
2d241f3 
full diff: tonistiigi/xx@v1.4.0...v1.5.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah merged commit db1da9d into docker:master Oct 25, 2024
@thaJeztah thaJeztah deleted the bump_xx branch October 25, 2024 11:54
@BrewTestBot BrewTestBot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

@thaJeztah thaJeztah

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @codecov-commenter @crazy-max