Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/moby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v28.1.0
Choose a base ref
...
head repository: moby/moby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v28.1.1
Choose a head ref
  • 11 commits
  • 70 files changed
  • 5 contributors

Commits on Apr 17, 2025

  1. Warn when no external DNS nameservers are found

    Since commit 925b484 ("No fallback nameservers for internal
    resolver"), if the host's resolv.conf has no nameservers and
    no servers are supplied via config, the internal resolver will
    not use Google's DNS - so the container will not be able to
    resolve external DNS requests.
    
    That can happen when container's are "restart-always" and the
    docker daemon starts before the host's DNS is configured.
    
    So, to highlight the issue (which may not be an error, but
    probably is), include a warning in the container's resolv.conf
    file.
    
    Also, log a warning - logs currently say "No non-localhost DNS
    nameservers are left in resolv.conf. Using default external
    servers". But, that's misleading because it's from an initial
    resolv.conf setup, before the internal resolver configured without
    those fallbacks - we'll drop the fallbacks completely once the
    default bridge has an internal resolver).
    
    Signed-off-by: Rob Murray <rob.murray@docker.com>
    robmry committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    619f1dd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #49827 from robmry/warn_no_ext_nameservers

    Warn when no external DNS nameservers are found
    robmry authored Apr 17, 2025
    Configuration menu
    Copy the full SHA
    6573a13 View commit details
    Browse the repository at this point in the history
  3. update go:build tags to go1.23 to align with vendor.mod

    Go maintainers started to unconditionally update the minimum go version
    for golang.org/x/ dependencies to go1.23, which means that we'll no longer
    be able to support any version below that when updating those dependencies;
    
    > all: upgrade go directive to at least 1.23.0 [generated]
    >
    > By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
    > per the Go Release Policy (https://go.dev/doc/devel/release#policy).
    >
    > For golang/go#69095.
    
    This updates our minimum version to go1.23, as we won't be able to maintain
    compatibility with older versions because of the above.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    7c52c4d View commit details
    Browse the repository at this point in the history
  4. contrib/rootless-setuptool: Fix iptables detection

    Fix a logical error in the rootless setup tool where the iptables error
    handling was incorrectly placed. The code was setting
    `faced_iptables_error=1` even when iptables was available, causing
    unnecessary error messages and setup suggestions.
    
    This patch correctly moves the error handling into the `else` branch so
    that we only report iptables errors when the command is actually
    unavailable.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    ead379a View commit details
    Browse the repository at this point in the history
  5. cleanup ignore files

    - We now only use winresources for the dockerd binary, so we can
      reduce some uses of wildcards
    - Use explicit ("/") to indicate these should only be ignored
      relative to the root of the repository and build-context
    - Remove remnant ignore for rpm builds
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    bbbb003 View commit details
    Browse the repository at this point in the history
  6. vendor: golang.org/x/oauth2 v0.29.0

    notable changes
    
    - oauth2.go: use a more straightforward return value
    - oauth2: Deep copy context client in NewClient
    - jws: improve fix for CVE-2025-22868
    
    full diff: golang/oauth2@v0.27.0...v0.29.0
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    62f51e4 View commit details
    Browse the repository at this point in the history
  7. vendor: github.com/containerd/containerd v2.0.5

    full diff: containerd/containerd@v2.0.4...v2.0.5
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    fc8361c View commit details
    Browse the repository at this point in the history
  8. Merge pull request #49833 from vvoland/rootless-iptables-check

    contrib/rootless-setuptool: Fix iptables detection
    AkihiroSuda authored Apr 17, 2025
    Configuration menu
    Copy the full SHA
    e70ce7a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2025

  1. Merge pull request #49837 from thaJeztah/bump_containerd_2.0.5

    vendor: github.com/containerd/containerd v2.0.5, golang.org/x/oauth2 v0.29.0
    AkihiroSuda authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    8dde918 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #49834 from thaJeztah/cleanup_ignore

    cleanup ignore files
    AkihiroSuda authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    e03c0f0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #49588 from thaJeztah/bump_go_build_tags

    update go:build tags to go1.23 to align with vendor.mod
    AkihiroSuda authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    01f442b View commit details
    Browse the repository at this point in the history
Loading