Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/moby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v27.0.1
Choose a base ref
...
head repository: moby/moby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v27.0.2
Choose a head ref
  • 6 commits
  • 6 files changed
  • 2 contributors

Commits on Jun 26, 2024

  1. api/types: deprecate ContainerJSONBase.Node, ContainerNode 

    The `Node` field and related `ContainerNode` type were used by the classic
(standalone) Swarm API. API documentation for this field was already removed
in 234d5a7 (API 1.41 / docker 20.10), and
as the Docker Engine didn't implement these fields for the Swarm API, it
would always have been unset / nil.

Let's do a quick deprecation, and remove it on the next release.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 1fc9236)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4587688 View commit details
    Browse the repository at this point in the history

  2. builder/remotecontext: reformat code to make #nosec comment work again 

    Looks like the way it picks up #nosec comments changed, causing the
linter error to re-appear;

    builder/remotecontext/remote.go:48:17: G107: Potential HTTP request made with variable url (gosec)
        if resp, err = http.Get(address); err != nil {
                       ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 04bf0e3)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c0ff08a View commit details
    Browse the repository at this point in the history

  3. pkg/archive: reformat code to make #nosec comment work again 

    Looks like the way it picks up #nosec comments changed, causing the
linter error to re-appear;

    pkg/archive/archive_linux.go:57:17: G305: File traversal when extracting zip/tar archive (gosec)
                    Name:       filepath.Join(hdr.Name, WhiteoutOpaqueDir),
                                ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit d4160d5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c95b917 View commit details
    Browse the repository at this point in the history

  4. update golangci-lint to v1.59.1 

    full diff: golangci/golangci-lint@v1.55.2...v1.59.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 95fae03)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3557077 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #48061 from thaJeztah/27_backport_bump_golangci_lint 

    [27.0 backport] update golangci-lint to v1.59.1
    @vvoland
    vvoland authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    861fde8 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #48060 from thaJeztah/27.0_backport_api_deprecate_… 

    …ContainerJSONBase_Node

[27.0 backport] api/types: deprecate ContainerJSONBase.Node, ContainerNode
    @vvoland
    vvoland authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e953d76 View commit details
    Browse the repository at this point in the history
Loading