introduce stopAndRemoveContainer to share logic scaling down#11393
Merged
ndeloof merged 1 commit intodocker:mainfrom Jan 23, 2024
Merged
introduce stopAndRemoveContainer to share logic scaling down#11393ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11393 +/- ##
==========================================
- Coverage 56.71% 56.57% -0.15%
==========================================
Files 136 136
Lines 11547 11544 -3
==========================================
- Hits 6549 6531 -18
- Misses 4374 4388 +14
- Partials 624 625 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
introduced
stopAndRemoveContainerto share logic scaling down and removing container. To be used both bydownandconvergence.Related issue
fixes #11391
(not mandatory) A picture of a cute animal, if possible in relation to what you did