collect services to build using WithServices#11255
Merged
ndeloof merged 1 commit intodocker:mainfrom Dec 7, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11255 +/- ##
==========================================
- Coverage 56.34% 56.29% -0.05%
==========================================
Files 134 134
Lines 11560 11564 +4
==========================================
- Hits 6513 6510 -3
- Misses 4407 4413 +6
- Partials 640 641 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
milas
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
as we determine
serviceToBeBuildwe don't need to respect dependency order and get low benefit relying on concurrent goroutines execution. We can rely on simplerWithServices