Fix configs are mounted under /<id>#11232
Merged
ndeloof merged 1 commit intodocker:mainfrom Nov 29, 2023
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11232 +/- ##
==========================================
- Coverage 56.87% 56.85% -0.02%
==========================================
Files 133 133
Lines 11503 11521 +18
==========================================
+ Hits 6542 6550 +8
- Misses 4325 4333 +8
- Partials 636 638 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix inlined and environment-defined configs to be mounted under
/<id>until an explicit target is setincludes a test case to avoid such a regression to appear again
Related issue
see compose-spec/compose-spec#346 (comment)
(not mandatory) A picture of a cute animal, if possible in relation to what you did