introduce compose logs --index to select a replica container #11231
Merged
ndeloof merged 6 commits intodocker:mainfrom Nov 29, 2023
Merged
introduce compose logs --index to select a replica container #11231ndeloof merged 6 commits intodocker:mainfrom
ndeloof merged 6 commits intodocker:mainfrom
Conversation
Signed-off-by: Amit Saha <asaha@atlassian.com>
Signed-off-by: Amit Saha <asaha@atlassian.com>
Signed-off-by: Amit Saha <asaha@atlassian.com>
Signed-off-by: Amit Saha <asaha@atlassian.com>
8f57d68 to
ddbe2af
Compare
Signed-off-by: Amit Saha <asaha@atlassian.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ddbe2af to
cc34eb4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11231 +/- ##
==========================================
- Coverage 56.81% 56.79% -0.03%
==========================================
Files 133 133
Lines 11500 11516 +16
==========================================
+ Hits 6534 6540 +6
- Misses 4329 4337 +8
- Partials 637 639 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
Hey @ndeloof thank you for getting this in! Did you have to do much or was the existing PR close to complete? |
Contributor
Author
|
@asaha123 yes this was close enough I just had to fix merge conflicts and move flag compatibility check to the command |
Contributor
|
thanks! |
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Apr 8, 2024
and missing `--dry-run` See docker/compose#11231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
introduce
compose logs --indexto select a replica containerRelated issue
closes #10130
(not mandatory) A picture of a cute animal, if possible in relation to what you did