send out a cancel event on SIGINT/SIGTERM signal for compose up#11230
Merged
ndeloof merged 1 commit intodocker:mainfrom Nov 30, 2023
Merged
send out a cancel event on SIGINT/SIGTERM signal for compose up#11230ndeloof merged 1 commit intodocker:mainfrom
compose up#11230ndeloof merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: vyneer <vyn33r@gmail.com>
ndeloof
approved these changes
Nov 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11230 +/- ##
=======================================
Coverage 56.81% 56.81%
=======================================
Files 133 133
Lines 11500 11500
=======================================
Hits 6534 6534
+ Misses 4329 4327 -2
- Partials 637 639 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Re-added the
printer.Cancel()call to the SIGINT/SIGTERM signal handling fordocker compose up. It being missing caused the output on Ctrl-C to be slightly messed up, due to%container% exited with code %code%messages interrupting the otherwise neat status info.Before and after
(not mandatory) A picture of a cute animal, if possible in relation to what you did
