Merged
Conversation
ecd997e to
f4e1c3f
Compare
2ab960d to
89e6e9e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11207 +/- ##
==========================================
- Coverage 56.88% 56.52% -0.36%
==========================================
Files 133 133
Lines 11513 11512 -1
==========================================
- Hits 6549 6507 -42
- Misses 4326 4364 +38
- Partials 638 641 +3 ☔ View full report in Codecov by Sentry. |
0d1696d to
83d2772
Compare
milas
reviewed
Nov 30, 2023
Contributor
milas
left a comment
There was a problem hiding this comment.
LGTM - just a couple small places where I think it's using a value where it needs a pointer
83d2772 to
bfdb619
Compare
1398882 to
9d4d65c
Compare
laurazard
reviewed
Dec 4, 2023
Member
laurazard
left a comment
There was a problem hiding this comment.
Overall LGTM, just a suggestion and a small callout
laurazard
approved these changes
Dec 5, 2023
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
9d4d65c to
4e7034c
Compare
milas
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
adopt compose-go/v2
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
