Conversation
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11331 +/- ##
==========================================
- Coverage 56.74% 56.61% -0.14%
==========================================
Files 134 134
Lines 11448 11448
==========================================
- Hits 6496 6481 -15
- Misses 4330 4342 +12
- Partials 622 625 +3 ☔ View full report in Codecov by Sentry. |
| ARG XX_VERSION=1.2.1 | ||
| ARG GOLANGCI_LINT_VERSION=v1.54.2 |
There was a problem hiding this comment.
Not for this PR, but there's newer versions of xx (v1.3.0) and GolangCI-lint (v1.55.2) that we may want to update as well.
For xx; I'm running into an issue when cross-compiling in docker/docker-credential-helpers#310, so just a heads-up on that.
There was a problem hiding this comment.
Thanks for the heads up, I'll open a couple new PRs for these
There was a problem hiding this comment.
golangci-lint PR @ #11332
Following the xx discussion, same issue on Compose side:
> [linux/arm64->darwin/amd64 build 1/1] RUN --mount=type=bind,target=. --mount=type=cache,target=/root/.cache --mount=type=cache,target=/go/pkg/mod --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk xx-go --wrap && if [ "$(xx-info os)" == "darwin" ]; then export CGO_ENABLED=1; fi && make build GO_BUILDTAGS="e2e" DESTDIR=/out && xx-verify --static /out/docker-compose:
1.355 GO111MODULE=on go build -trimpath -tags "e2e" -ldflags "-w -X github.com/docker/compose/v2/internal.Version=v2.24.0-birthday.10-39-gf5c53c2d0.m" -o "/out/docker-compose" ./cmd
201.4 # github.com/docker/compose/v2/cmd
201.4 /usr/local/go/pkg/tool/linux_arm64/link: running x86_64-apple-macos10.6-clang failed: exit status 1
201.4 /usr/bin/x86_64-apple-macos10.6-ld: line 9: sigtool-gensig: not found
201.4 clang: error: unable to execute command: No such file or directory
201.4 clang: error: linker command failed due to signal (use -v to see invocation)
201.4
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
What I did
Bump Golang to version
v1.21.6Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did