update compose-go to version using immutable Project functions#11307
Merged
glours merged 1 commit intodocker:mainfrom Jan 11, 2024
Merged
update compose-go to version using immutable Project functions#11307glours merged 1 commit intodocker:mainfrom
glours merged 1 commit intodocker:mainfrom
Conversation
2b15a47 to
b466fa3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11307 +/- ##
==========================================
- Coverage 56.69% 56.67% -0.02%
==========================================
Files 134 134
Lines 11448 11456 +8
==========================================
+ Hits 6490 6493 +3
- Misses 4336 4341 +5
Partials 622 622 ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Jan 8, 2024
85a15cd to
9e4fc83
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
9e4fc83 to
5d05df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging: need PR compose-spec/compose-go#518 to be merged and a new version of
compose-goto be releasedWhat I did
Test the version of
compose-gowhich introducesProjectimmutable functionscompose-gowith the version of the following PRcompose-goversion without using the advantage of the immutability for now, basically just replace the currentProjectinstance with the new one.Related issue
https://docker.atlassian.net/browse/COMP-380
(not mandatory) A picture of a cute animal, if possible in relation to what you did
