gha: add docker 28 to test matrix #5864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5864 +/- ##
=======================================
Coverage 59.27% 59.27%
=======================================
Files 353 353
Lines 29694 29694
=======================================
Hits 17601 17601
Misses 11113 11113
Partials 980 980 |
- set default to 28 - remove minor version from matrix; docker:dind images also provide a "docker:28-dind" which point to the latest minor version. - remove TODO for 19.03, which is really out of scope now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
12de085 to
427c136
Compare
thaJeztah
commented
Feb 24, 2025
Comment on lines
-44
to
-45
| # TODO(krissetto) 19.03 needs a look, doesn't work ubuntu 22.04 (cgroup errors). | ||
| # we could have a separate job that tests it against ubuntu 20.04 |
Member
Author
There was a problem hiding this comment.
Removed this TODO as well as we won't be spending time on this
vvoland
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)