Skip to content

Replace deprecated fs.rmdir with fs.rm#657

Merged
crazy-max merged 1 commit intodocker:masterfrom
bendrucker:deprecated-fs-rmdir
Jul 28, 2022
Merged

Replace deprecated fs.rmdir with fs.rm#657
crazy-max merged 1 commit intodocker:masterfrom
bendrucker:deprecated-fs-rmdir

Conversation

@bendrucker
Copy link
Copy Markdown
Contributor

@bendrucker bendrucker commented Jul 27, 2022

Fixes the following deprecation warning during cleanup:

(node:7106) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

https://nodejs.org/api/deprecations.html#DEP0147

@bendrucker bendrucker requested a review from crazy-max as a code owner July 27, 2022 23:44
@bendrucker
replace deprecated fs.rmdir with fs.rm
988cb09 
Signed-off-by: Ben Drucker <bvdrucker@gmail.com>
@bendrucker bendrucker force-pushed the deprecated-fs-rmdir branch from 5415970 to 988cb09 Compare July 27, 2022 23:47
crazy-max
crazy-max approved these changes Jul 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 67af6dc into docker:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bendrucker @crazy-max