revert "set repository and ghtoken attributes for gha cache type"#1183
Merged
crazy-max merged 2 commits intodocker:masterfrom Jul 17, 2024
Merged
revert "set repository and ghtoken attributes for gha cache type"#1183crazy-max merged 2 commits intodocker:masterfrom
crazy-max merged 2 commits intodocker:masterfrom
Conversation
This reverts commit 522345f. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #1181
#1133 introduces a change setting automatically
repositoryandghtokenattributes forghacache export type to be able to use the GitHub API for checking cache keys and avoid GitHub Actions cache API throttling but we got reports in #1181 showing a regression when writing blobs: #1181 (comment)While this is being investigating, let's revert this change.
@dvdksn Would need a follow-up in https://docs.docker.com/build/cache/backends/gha/#avoid-github-actions-cache-api-throttling to remove the part saying we set it automatically 🙏.