preserve quotes for set input fields#97
Merged
crazy-max merged 2 commits intodocker:masterfrom Apr 17, 2023
Merged
Conversation
ae45b6a to
f22eb39
Compare
c14678c to
78ccefc
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
78ccefc to
79237ba
Compare
jedevc
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/setup-buildx-action#175
There are cases where quotes need to be used for multi values fields like
namefor image typeoutput:Currently it would fail with: https://github.com/crazy-max/buildkit/actions/runs/3275927287/jobs/5391622084#step:7:122
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com