Skip to content

context: remove provenanceBuilderID func #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crazy-max merged 1 commit into from
Jan 15, 2025
Merged

context: remove provenanceBuilderID func #554

crazy-max merged 1 commit into from
Jan 15, 2025

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 15, 2025

This function is not used anymore and has been replaced by

actions-toolkit/src/github.ts

Lines 93 to 95 in 9881e80

public static workflowRunURL(setAttempts?: boolean): string {
return `${GitHub.serverURL}/${GitHub.repository}/actions/runs/${GitHub.runId}${setAttempts ? `/attempts/${GitHub.runAttempt}` : ''}`;
}

Used when solving provenance attributes:

actions-toolkit/src/buildx/build.ts

Line 162 in 9881e80

return core.getBooleanInput(name) ? `builder-id=${GitHub.workflowRunURL(true)}` : 'false';

@crazy-max
context: remove provenanceBuilderID func
f2e802c 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review January 15, 2025 11:24
@crazy-max crazy-max merged commit f795e92 into docker:main Jan 15, 2025
61 checks passed
@crazy-max crazy-max deleted the context-remove-provenanceBuilderID branch January 15, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@crazy-max