feat: add method to get commit date from git#489
Merged
crazy-max merged 1 commit intodocker:mainfrom Nov 13, 2024
Merged
Conversation
crazy-max
requested changes
Nov 13, 2024
Comment on lines
+167
to
+169
| public static async commitDate(ref: string, gitDir: string | undefined = undefined): Promise<Date> { | ||
| const args = ['show', '-s', '--format="%ci"', ref]; | ||
| if (gitDir !== undefined) { | ||
| args.push('--'); | ||
| args.push(gitDir); | ||
| } | ||
|
|
||
| return new Date(await Git.exec(args)); | ||
| } |
Member
There was a problem hiding this comment.
Don't think we need a gitDir opt like other methods we have:
public static async commitDate(ref: string): Promise<Date> {
return new Date(await Git.exec(['show', '-s', '--format="%ci"', ref]));
}Signed-off-by: Trim21 <trim21.me@gmail.com>
ca3f52f to
31cb9c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for docker/metadata-action#308
sorry to create this PR again, I did some force push and it cause github not working as expected.
and looks like ci failed with other tests, not caused be this PR？