Skip to content

buildx: build for local platform#135

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:fix-buildx-install-platform
Jul 12, 2023
Merged

buildx: build for local platform#135
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:fix-buildx-install-platform

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 12, 2023

When building buildx on macOS runner when Docker engine is installed it will build against linux/amd64 instead of darwin/amd64. We should always match the local platform.

cc @maxcleme

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested review from jedevc and tonistiigi July 12, 2023 12:16
Copy link
Member

@maxcleme maxcleme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@crazy-max crazy-max merged commit f1593e3 into docker:main Jul 12, 2023
@crazy-max crazy-max deleted the fix-buildx-install-platform branch July 12, 2023 12:23
Mogyuchi referenced this pull request in 4m-mazi/gh-test Jul 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action)
| action | minor | `v2.8.0` -> `v2.9.1` |

---

### Release Notes

<details>
<summary>docker/setup-buildx-action
(docker/setup-buildx-action)</summary>

###
[`v2.9.1`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.9.1)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.9.0...v2.9.1)

- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.7.0 to 0.7.1 in
[https://github.com/docker/setup-buildx-action/pull/248](https://togithub.com/docker/setup-buildx-action/pull/248)
- Fixes an issue where building Buildx does not match the local platform
([https://github.com/docker/actions-toolkit/pull/135](https://togithub.com/docker/actions-toolkit/pull/135))

**Full Changelog**:
docker/setup-buildx-action@v2.9.0...v2.9.1

###
[`v2.9.0`](https://togithub.com/docker/setup-buildx-action/releases/tag/v2.9.0)

[Compare
Source](https://togithub.com/docker/setup-buildx-action/compare/v2.8.0...v2.9.0)

- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.6.0 to 0.7.0 in
[https://github.com/docker/setup-buildx-action/pull/246](https://togithub.com/docker/setup-buildx-action/pull/246)
- Adds support to cache Buildx binary to hosted tool cache and GHA cache
backend

**Full Changelog**:
docker/setup-buildx-action@v2.8.0...v2.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Mogyuchi/gh-test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNyIsInVwZGF0ZWRJblZlciI6IjM2LjUuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants