fix: support escape sequences in tagged templates#107
Merged
JoshuaKGoldberg merged 3 commits intodmnd:mainfrom Mar 1, 2026
Merged
fix: support escape sequences in tagged templates#107JoshuaKGoldberg merged 3 commits intodmnd:mainfrom
JoshuaKGoldberg merged 3 commits intodmnd:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@JoshuaKGoldberg, when you have the chance, could you please review this? |
Collaborator
|
👋 thanks for the ping, and sorry for the delay! Looking now. |
JoshuaKGoldberg
approved these changes
Feb 28, 2026
Collaborator
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! Just one suggestion around tests that doesn't need to block merging. Let me know if you don't have time to apply it and I always can later this week. Thanks again @marcalexiei! 🙌
JoshuaKGoldberg
approved these changes
Mar 1, 2026
Collaborator
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
🔥 awesome, thanks!
|
🎉 This is included in version v1.7.2 🎉 The release is available on: Cheers! 📦🚀 |
|
@marcalexiei @JoshuaKGoldberg I think escaping the escape character is still a problem, #95 (comment) is still valid even after this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Fixes support for escape sequences in tagged templates by preserving raw template parts and unescaping explicit character escapes (e.g.
\n,\t,\xHH,\uXXXX,\u{...}) only after indentation and trimming.