feat: add SES Global Endpoint (Multi-Region Endpoint) support#367
Merged
pcraciunoiu merged 3 commits intodjango-ses:mainfrom Feb 3, 2026
Merged
Conversation
Add support for AWS SES Global Endpoints (Multi-Region Endpoints) which provide multi-region high availability and automatic failover between two AWS regions. Changes: - Add AWS_SES_GLOBAL_ENDPOINT_ID setting to configure endpoint ID - Implement EndpointId parameter in send_email API calls (SESv2 only) - Add validation to ensure SESv2 is enabled when using global endpoints - Add comprehensive test coverage for global endpoint functionality - Update documentation with setup instructions and usage examples The implementation: - Maintains full backward compatibility (default: None) - Requires USE_SES_V2=True (validated at runtime) - Follows existing code patterns and project conventions - Includes 4 new test classes covering all scenarios Closes #XXX
pcraciunoiu
reviewed
Feb 2, 2026
Contributor
pcraciunoiu
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This seems like an easy feature to add.
I've approved the tests to run and just one small comment came to mind.
Comment on lines
+46
to
+54
|
|
||
| @override_settings(AWS_SES_GLOBAL_ENDPOINT_ID='test123.g3h') | ||
| def test_global_endpoint_id_given(self): | ||
| """Test that global endpoint ID is set when AWS_SES_GLOBAL_ENDPOINT_ID is provided""" | ||
| self.assertEqual(settings.AWS_SES_GLOBAL_ENDPOINT_ID, 'test123.g3h') | ||
|
|
||
| def test_global_endpoint_id_default(self): | ||
| """Test that global endpoint ID defaults to None""" | ||
| self.assertIsNone(settings.AWS_SES_GLOBAL_ENDPOINT_ID) |
Contributor
There was a problem hiding this comment.
The first test is not worth adding IMO.
I'm inclined to remove the second as well, just because testing default values doesn't seem interesting.
Contributor
Author
There was a problem hiding this comment.
Thank you for your review. I have removed the unnecessary tests.
Contributor
|
This looks good but GitHub CI is down, so I'll wait to approve and merge until it's back. |
Contributor
|
@tomoyasu-sasaki all good except some lint issue, would you fix? |
Contributor
Author
|
Sure, I've fixed it. |
pcraciunoiu
approved these changes
Feb 3, 2026
Contributor
|
Published to v4.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for AWS SES Global Endpoints (Multi-Region Endpoints) which provide multi-region high availability and automatic failover between two AWS regions.
Changes:
The implementation: