Skip to content

Issue #322 AWS Session Integration#323

Merged
pcraciunoiu merged 1 commit intodjango-ses:mainfrom
SaiVenkatDhulipudi:issue-322
May 22, 2024
Merged

Issue #322 AWS Session Integration#323
pcraciunoiu merged 1 commit intodjango-ses:mainfrom
SaiVenkatDhulipudi:issue-322

Conversation

@SaiVenkatDhulipudi
Copy link
Copy Markdown
Contributor

@pcraciunoiu
Copy link
Copy Markdown
Contributor

Thanks @SaiVenkatDhulipudi this is going to be too difficult to review with all the lint changes.

Is there any way you can revert those, and put them in a separate PR?

@SaiVenkatDhulipudi SaiVenkatDhulipudi force-pushed the issue-322 branch 2 times, most recently from 733af30 to 18010a2 Compare May 20, 2024 20:17
@SaiVenkatDhulipudi
Copy link
Copy Markdown
Contributor Author

Updated the PR...could you please check now...?

@SaiVenkatDhulipudi SaiVenkatDhulipudi force-pushed the issue-322 branch 2 times, most recently from 398822d to cb2f1f3 Compare May 20, 2024 20:26
@pcraciunoiu
Copy link
Copy Markdown
Contributor

There are still a few files that have lint changes. If it's not too time consuming, please revert those too. I will review later this week either way.

@SaiVenkatDhulipudi
Copy link
Copy Markdown
Contributor Author

There are still a few files that have lint changes. If it's not too time consuming, please revert those too. I will review later this week either way.

I will raise a pr with linting added first then raise a pr for session authentication
hope that works...

@SaiVenkatDhulipudi
Copy link
Copy Markdown
Contributor Author

I have updated the pr, Could you please review this

@pcraciunoiu
Copy link
Copy Markdown
Contributor

@SaiVenkatDhulipudi were you able to test this manually using

  1. the previous configuration options, without session profile
  2. the new session profile setting

I just want to make sure both worked for you.

Code changes look good to me.

@SaiVenkatDhulipudi
Copy link
Copy Markdown
Contributor Author

@pcraciunoiu Yes both worked for me...

@pcraciunoiu pcraciunoiu merged commit 90cea76 into django-ses:main May 22, 2024
Copy link
Copy Markdown
Contributor

@pcraciunoiu pcraciunoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcraciunoiu
Copy link
Copy Markdown
Contributor

Released in v4.1.0 - https://pypi.org/project/django-ses/4.1.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants