Skip to content

fix: update typing for webpack@^5.94.0#110

Merged
jonaskello merged 2 commits intojonaskello:masterfrom
technology-studio-forks:master
Nov 1, 2024
Merged

fix: update typing for webpack@^5.94.0#110
jonaskello merged 2 commits intojonaskello:masterfrom
technology-studio-forks:master

Conversation

@rostislav-simonik
Copy link
Copy Markdown
Contributor

Fixes #109

@rostislav-simonik
Copy link
Copy Markdown
Contributor Author

@jonaskello do you think you could review?

@jonaskello
Copy link
Copy Markdown
Owner

Gave it a quick test and it seems OK. I guess this should be released as a minor increment?

@jonaskello jonaskello merged commit 5a0b8d8 into jonaskello:master Nov 1, 2024
@Txabs
Copy link
Copy Markdown

Txabs commented Nov 1, 2024

Build failed https://github.com/dividab/tsconfig-paths-webpack-plugin/actions/runs/11630770484/job/32390428277

error eslint-plugin-jsdoc@39.9.1: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.18.0"

@rostislav-simonik @jonaskello

@rostislav-simonik
Copy link
Copy Markdown
Contributor Author

rostislav-simonik commented Nov 1, 2024

Gave it a quick test and it seems OK. I guess this should be released as a minor increment?

I haven't tested it on an older Webpack version. it would be good to see if it's backwards compatible. If not, then it's breaking change.

@rostislav-simonik
Copy link
Copy Markdown
Contributor Author

Build failed https://github.com/dividab/tsconfig-paths-webpack-plugin/actions/runs/11630770484/job/32390428277

error eslint-plugin-jsdoc@39.9.1: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.18.0"

@rostislav-simonik @jonaskello

I can check later today on how to address this issue.

@rostislav-simonik
Copy link
Copy Markdown
Contributor Author

Build failed https://github.com/dividab/tsconfig-paths-webpack-plugin/actions/runs/11630770484/job/32390428277
error eslint-plugin-jsdoc@39.9.1: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.18.0"
@rostislav-simonik @jonaskello

I can check later today on how to address this issue.

The issue is unrelated, but I created a PR to address it: #111

@rostislav-simonik
Copy link
Copy Markdown
Contributor Author

@jonaskello minor should be fine. I tested it with the previous version, 5.65.0, and it works.

@Txabs
Copy link
Copy Markdown

Txabs commented Nov 11, 2024

thank you guys...

any idea of when this fix will be available publicly in master?

I'm still seeing 4.1.0 as the latest version in https://www.npmjs.com/package/tsconfig-paths-webpack-plugin

(and that's also the version I'm getting when I do a yarn add -D tsconfig-paths-webpack-plugin)

@jonaskello
Copy link
Copy Markdown
Owner

This is now published in 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type error after upgrading to webpack@5.94.0 (A class can only implement an object type or intersection of object types with statically known members.)

3 participants