Skip to content

fix: implement JWK thumbprint for Ed25519 public keys#4626

Merged
milosgajdos merged 1 commit into
distribution:mainfrom
zhangyoufu:Ed25519
Apr 23, 2025
Merged

fix: implement JWK thumbprint for Ed25519 public keys#4626
milosgajdos merged 1 commit into
distribution:mainfrom
zhangyoufu:Ed25519

Conversation

@zhangyoufu

@zhangyoufu zhangyoufu commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

In #4471, we implemented JWK fingerprint for RSA and ECDSA public keys, in accordance to RFC 7638.
This PR implemented JWK fingerprint for Ed25519 public keys, in accordance to RFC 8037.

@milosgajdos

Copy link
Copy Markdown
Member

Please sign your DCO @zhangyoufu

@zhangyoufu zhangyoufu force-pushed the Ed25519 branch 2 times, most recently from 2fcf05f to 7a4fec6 Compare April 18, 2025 11:44
@zhangyoufu

Copy link
Copy Markdown
Contributor Author

Please sign your DCO @zhangyoufu

@milosgajdos DCO done. Force-pushed. Workflows awaiting approval.

@milosgajdos milosgajdos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @thaJeztah

Comment thread registry/auth/token/util.go Outdated
Comment thread registry/auth/token/util.go
Signed-off-by: Youfu Zhang <zhangyoufu@gmail.com>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit e827ce2 into distribution:main Apr 23, 2025
@zhangyoufu zhangyoufu deleted the Ed25519 branch April 23, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants